Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIO-8450: Fix custom error message for unique validation #106

Merged
merged 1 commit into from
Jun 29, 2024
Merged

FIO-8450: Fix custom error message for unique validation #106

merged 1 commit into from
Jun 29, 2024

Conversation

mikekotikov
Copy link
Contributor

@mikekotikov mikekotikov commented Jun 19, 2024 •
edited
Loading

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8450

Description

What changed?

Custom validation error messages were not populated, this PR adds a fix

Why have you chosen this solution?

Use this section to justify your choices

Breaking Changes / Backwards Compatibility

Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility

Dependencies

formio:1759

How has this PR been tested?

Test is added in formio:1759

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@mikekotikov mikekotikov force-pushed the fix/FIO-8450_custom_error_message_for_unique_broken branch from d991bbd to 01ba93e Compare June 19, 2024 11:50
@mikekotikov mikekotikov mentioned this pull request Jun 19, 2024
Merged
7 tasks
brendanbond
brendanbond requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@brendanbond brendanbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know your thoughts

src/process/validation/util.ts Show resolved Hide resolved
@mikekotikov mikekotikov force-pushed the fix/FIO-8450_custom_error_message_for_unique_broken branch from 00ab6f0 to e6907d8 Compare June 27, 2024 10:10
@mikekotikov mikekotikov requested a review from brendanbond June 27, 2024 10:11
@mikekotikov mikekotikov force-pushed the fix/FIO-8450_custom_error_message_for_unique_broken branch from e6907d8 to 01ba93e Compare June 28, 2024 09:11
@mikekotikov
Copy link
Contributor Author

@brendanbond rechecked with the first commit implementation, this way any custom validation messages are applied (unique, required, min, max, etc.)

@brendanbond brendanbond merged commit 7fd12b0 into master Jun 29, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendanbond brendanbond brendanbond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikekotikov @brendanbond